Chris Ryland says:

Sat, 01 Mar 2008 17:30:20 +0000

Perhaps too nit-picky, my DRY "code smell sense" suggests you replace that last if with something like the following, "hoisting out" the small difference in those two returns:

NSString *format;

if ((float) (result - (int) result) > 0.01)
format = @"%.2f %@";
else
format = @"%.0f %@";
return [NSString localizedStringWithFormat:format, result, [sizeTable objectAtIndex:i]];

Quinn Taylor says:

Wed, 16 Sep 2009 03:58:47 +0000

Concise is always good. In my own adapted code, I took it a few steps further... My version accepts a string or an NSNumber, and does away with the counter variable. (The for-in loop works on 10.5 and higher.) Thanks for the ideas!

- (NSString*) stringForIntegerValue:(NSInteger)integerValue {
NSArray *suffixes = [NSArray arrayWithObjects:@"B", @"KB", @"MB", @"GB", @"TB", @"PB", nil];
float value = integerValue;
for (NSString *suffix in suffixes) {
if (value >= 1024) {
value /= 1024;
} else {
NSString *format = (value - (int)value >= 0.1) ? @"%.1f %@" : @"%.0f %@";
return [NSString localizedStringWithFormat:format, value, suffix];
}
}
}

- (NSString*) stringForObjectValue:(id)anObject {
return [self stringForIntegerValue:[anObject integerValue]];
}

Comments for BSByteFormatter

Chris Ryland says:

Quinn Taylor says: